Discussion:
[emms-help] [PATCH] Add support for dynamic thumbnail caching
Pierre Neidhardt
2017-12-03 19:08:57 UTC
Permalink
To enable dynamic caching, simply

(setq emms-browser-covers 'emms-browser-cache-thumbnail)

Let me know if you spot anything spurious.

It's quite slow at the moment (about 30 seconds on my machine to run
`emms-browse-expand-all' on 1500 covers). Can we make this faster?

If not, should we display the covers asynchronously just like EMMS does
for the tags?
Pierre Neidhardt
2017-12-03 20:12:36 UTC
Permalink
Just realized my previous e-mail was a tad concise...

The aforementioned patch enables automatic resizing of the album's cover
artwork so that it can be displayed in EMMS without user intervention
(i.e. manual renaming and manual resizing).

The thumbnails (the resized covers) are cached to speed up the future queries.

--
Pierre Neidhardt

Nick the Greek's Law of Life:
All things considered, life is 9 to 5 against.
Yoni Rabkin
2017-12-03 20:44:32 UTC
Permalink
Post by Pierre Neidhardt
Just realized my previous e-mail was a tad concise...
The aforementioned patch enables automatic resizing of the album's cover
artwork so that it can be displayed in EMMS without user intervention
(i.e. manual renaming and manual resizing).
The thumbnails (the resized covers) are cached to speed up the future queries.
I think that most users will forgive a slow process if it:

* Happens in order to speed things up in the future.

* Displayed an in-progresses percentage, or "x/y complete" while
it's working.

If it doesn't break in any dramatic way, it would be great if you can
commit this so that people who use the browser (which I assume is most
of them) can play with it and provide feedback.

Other points:

* Public facing features should be documented in the Fine Manual
(TM).

* Once it works resonably well, please add it to NEWS in "News since
version 4.4"

thanks!
--
"Cut your own wood and it will warm you twice"
Pierre Neidhardt
2017-12-09 15:40:27 UTC
Permalink
Alright, I've pushed the changes upstream.

An in-progress percentage is displayed whenever
emms-browser-expand-to-level is used. Hopefully that covers all cases.

I've updated the doc, feel free to revise it.

Next steps:

- Optimize and possibly make an async version.

- Remove the old static cover support? That would simplify code and
user configuration.

Feedback is more than welcome! :)

Enjoy!

--
Pierre Neidhardt

If only Dionysus were alive! Where would he eat?
-- Woody Allen
Yoni Rabkin
2017-12-09 17:12:24 UTC
Permalink
Post by Pierre Neidhardt
Alright, I've pushed the changes upstream.
Excellent, thank you.
Post by Pierre Neidhardt
An in-progress percentage is displayed whenever
emms-browser-expand-to-level is used. Hopefully that covers all cases.
I've updated the doc, feel free to revise it.
- Optimize and possibly make an async version.
- Remove the old static cover support? That would simplify code and
user configuration.
Feedback is more than welcome! :)
People who use the browser: please test this and provide feedback.
--
"Cut your own wood and it will warm you twice"
Loading...