[emms-help] emms-player-mpg321-remote patch to make it autoplay on newest version of mpg321

[pin to]

According to the link in the patch @P3 signals stop and that was the
only signal I ever got so I added it and now autoplay works. Please
consider adding this to the emms files in order to help people in the
same boat as I was.


Patch follows

commit a23d5f19ab5efbc5f57162153c5ec448aa493723
Author: pinto <***@gmail.com>
Date: Tue May 30 22:23:19 2017 +0000

This fixes auto playing not working. Seems @P3 is the new mpg321
signal for song being over, so both P0 and P3 should be checked. SRC:
https://www.apt-browse.org/browse/debian/wheezy/main/i386/mpg321/0.3.2-1.1/file/usr/share/doc/mpg321/README.remote

diff --git a/lisp/emms-player-mpg321-remote.el
b/lisp/emms-player-mpg321-remote.el
index 85f506c..8afe11a 100644
--- a/lisp/emms-player-mpg321-remote.el
+++ b/lisp/emms-player-mpg321-remote.el
@@ -153,7 +153,7 @@ For example: (list \"-o\" \"alsa\")"
(cond
;; stop notice
((and (string= cmd "@P")
- (string= (cadr data) "0"))
+ (or (string= (cadr data) "0") (string= (cadr data "3") ))
(emms-player-mpg321-remote-notify-emms))
;; frame notice
((string= cmd "@F")

[Yoni Rabkin]

Thanks for the patch. I'll have a look at it ASAP.

Post by pin to
only signal I ever got so I added it and now autoplay works. Please
consider adding this to the emms files in order to help people in the
same boat as I was.
Patch follows
commit a23d5f19ab5efbc5f57162153c5ec448aa493723
Date: Tue May 30 22:23:19 2017 +0000
https://www.apt-browse.org/browse/debian/wheezy/main/i386/mpg321/0.3.2-1.1/file/usr/share/doc/mpg321/README.remote
diff --git a/lisp/emms-player-mpg321-remote.el
b/lisp/emms-player-mpg321-remote.el
index 85f506c..8afe11a 100644
--- a/lisp/emms-player-mpg321-remote.el
+++ b/lisp/emms-player-mpg321-remote.el
@@ -153,7 +153,7 @@ For example: (list \"-o\" \"alsa\")"
(cond
;; stop notice
- (string= (cadr data) "0"))
+ (or (string= (cadr data) "0") (string= (cadr data "3") ))
(emms-player-mpg321-remote-notify-emms))
;; frame notice
_______________________________________________
Emms-help mailing list
https://lists.gnu.org/mailman/listinfo/emms-help

[Yoni Rabkin]

Post by pin to
only signal I ever got so I added it and now autoplay works. Please
consider adding this to the emms files in order to help people in the
same boat as I was.

This has been applied, including fixing your paren weirdness (look at
the bit after the second 'cadr data'). Can you please check this against
the git version?

Thank you for the patch.

Post by pin to
Patch follows
commit a23d5f19ab5efbc5f57162153c5ec448aa493723
Date: Tue May 30 22:23:19 2017 +0000
https://www.apt-browse.org/browse/debian/wheezy/main/i386/mpg321/0.3.2-1.1/file/usr/share/doc/mpg321/README.remote
diff --git a/lisp/emms-player-mpg321-remote.el
b/lisp/emms-player-mpg321-remote.el
index 85f506c..8afe11a 100644
--- a/lisp/emms-player-mpg321-remote.el
+++ b/lisp/emms-player-mpg321-remote.el
@@ -153,7 +153,7 @@ For example: (list \"-o\" \"alsa\")"
(cond
;; stop notice
- (string= (cadr data) "0"))
+ (or (string= (cadr data) "0") (string= (cadr data "3") ))
(emms-player-mpg321-remote-notify-emms))
;; frame notice
_______________________________________________
Emms-help mailing list
https://lists.gnu.org/mailman/listinfo/emms-help