Fran Burstall
2018-06-20 20:35:48 UTC
The (not very important) issue: in a playlist buffer I hit
// (emms-playlist-limit-to-all).
What I expect to happen: nothing if the playlist is already
unlimited.
What happens: the playlist has its order reversed.
Commentary: emms-playlist-limit-to-all refills the playlist
from a list created by a previous application of
emms-playlist-tracks-in-region. The latter lists the tracks of the
region in reverse order on account of just consing up said list
from the top.
Please consider applying the following tiny patch to
emms-playlist-tracks-in-region.
---Fran
diff --git a/lisp/emms.el b/lisp/emms.el
index 062b6eb..7a14a9e 100644
--- a/lisp/emms.el
+++ b/lisp/emms.el
@@ -1098,7 +1098,7 @@ This is supplying ARGS as arguments to the source."
(emms-walk-tracks
(setq tracks (cons (emms-playlist-track-at (point))
tracks))))
- tracks))
+ (nreverse tracks)))
(defun emms-playlist-track-updated (track)
"Update TRACK in all playlist buffers."
// (emms-playlist-limit-to-all).
What I expect to happen: nothing if the playlist is already
unlimited.
What happens: the playlist has its order reversed.
Commentary: emms-playlist-limit-to-all refills the playlist
from a list created by a previous application of
emms-playlist-tracks-in-region. The latter lists the tracks of the
region in reverse order on account of just consing up said list
from the top.
Please consider applying the following tiny patch to
emms-playlist-tracks-in-region.
---Fran
diff --git a/lisp/emms.el b/lisp/emms.el
index 062b6eb..7a14a9e 100644
--- a/lisp/emms.el
+++ b/lisp/emms.el
@@ -1098,7 +1098,7 @@ This is supplying ARGS as arguments to the source."
(emms-walk-tracks
(setq tracks (cons (emms-playlist-track-at (point))
tracks))))
- tracks))
+ (nreverse tracks)))
(defun emms-playlist-track-updated (track)
"Update TRACK in all playlist buffers."