Discussion:
[emms-help] [PATCH] Follow symlinks when using GNU find
Maxim Cournoyer
2017-09-13 19:40:00 UTC
Permalink
Hi!

When choosing `emms-source-file-directory-tree-find' as the function to
perform file discovery with the following snippet in my .emacs:

--8<---------------cut here---------------start------------->8---
(require 'emms-setup)
(emms-all)
(emms-default-players)
(setq emms-source-file-directory-tree-function
#'emms-source-file-directory-tree-find)
(setq emms-source-file-default-directory "~/Music/")
--8<---------------cut here---------------end--------------->8---

Then when using M-x emms-add-directory-tree RET ~/Music/ RET, symlinks
are not followed (I have a symlink pointing to a music collection on
external storage). This was reported in 2014[1] but it seems that it
failed to be noticed/merged (as of EMMS 4.3).

The attached trivial (one line) patch adds the -L option to the
find command and enables the use of symlinks in a music collection
directory.

Thanks for this useful of software!

Maxim

[1] https://lists.gnu.org/archive/html/emms-help/2014-01/msg00003.html
Yoni Rabkin
2017-09-13 20:09:07 UTC
Permalink
Post by Maxim Cournoyer
Hi!
When choosing `emms-source-file-directory-tree-find' as the function to
(require 'emms-setup)
(emms-all)
(emms-default-players)
(setq emms-source-file-directory-tree-function
#'emms-source-file-directory-tree-find)
(setq emms-source-file-default-directory "~/Music/")
Then when using M-x emms-add-directory-tree RET ~/Music/ RET, symlinks
are not followed (I have a symlink pointing to a music collection on
external storage). This was reported in 2014[1] but it seems that it
failed to be noticed/merged (as of EMMS 4.3).
The attached trivial (one line) patch adds the -L option to the
find command and enables the use of symlinks in a music collection
directory.
Thanks for this useful of software!
Patched and pushed to the Savannah git repo. Thank you.
--
"Cut your own wood and it will warm you twice"
Maxim Cournoyer
2017-09-14 19:22:22 UTC
Permalink
Post by Yoni Rabkin
Post by Maxim Cournoyer
Hi!
When choosing `emms-source-file-directory-tree-find' as the function to
(require 'emms-setup)
(emms-all)
(emms-default-players)
(setq emms-source-file-directory-tree-function
#'emms-source-file-directory-tree-find)
(setq emms-source-file-default-directory "~/Music/")
Then when using M-x emms-add-directory-tree RET ~/Music/ RET, symlinks
are not followed (I have a symlink pointing to a music collection on
external storage). This was reported in 2014[1] but it seems that it
failed to be noticed/merged (as of EMMS 4.3).
The attached trivial (one line) patch adds the -L option to the
find command and enables the use of symlinks in a music collection
directory.
Thanks for this useful of software!
Patched and pushed to the Savannah git repo. Thank you.
That was quick! Thank you! :)

Maxim

Loading...